Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stringId as param in string comments #54

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

ShivamGarg2910
Copy link
Contributor

No description provided.

@andrii-bodnar
Copy link
Member

@ShivamGarg2910 thanks a lot for your contribution!

Just left some comments, please take a look

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Merging #54 (9a462e4) into main (1951497) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          99       99           
  Lines        2058     2058           
  Branches      256      256           
=======================================
  Hits         2031     2031           
  Misses         21       21           
  Partials        6        6           
Impacted Files Coverage Δ
...wdin_api/api_resources/string_comments/resource.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrii-bodnar andrii-bodnar merged commit d25f098 into crowdin:main Oct 23, 2022
@andrii-bodnar andrii-bodnar linked an issue Oct 23, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing StringId param in add_string_comment
3 participants