Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update dependencies version (#615) #673

Merged
merged 2 commits into from Oct 26, 2023

Conversation

ddninja
Copy link
Contributor

@ddninja ddninja commented Oct 21, 2023

Updated minor and patch version of dependencies listed on version.properties

@ddninja ddninja changed the title Fix issue #615: Updated minor and patch version fix: Update dependencies version (#615) Oct 21, 2023
@andrii-bodnar andrii-bodnar linked an issue Oct 23, 2023 that may be closed by this pull request
@andrii-bodnar andrii-bodnar added the hacktoberfest This issue welcomes contributions for Hacktoberfest label Oct 23, 2023
@andrii-bodnar
Copy link
Member

@ddninja thank you! The CI build has failed, could you please take a look?

@ddninja
Copy link
Contributor Author

ddninja commented Oct 23, 2023

@andrii-bodnar On checking I found out that the pipeline is failing because of upgrading the commons-io library.
on reverting it to 2.11.0 it is passing the pipeline.
In commons-io version 2.14.0 (updated version) , IOUtils.readLines() throw UncheckedIOException instead of IOException (as in 2.11.0).
I will update the catch statement for catching UncheckedIOException.

@andrii-bodnar
Copy link
Member

@ddninja updating the catch statement sounds good to me.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #673 (f1ffdb5) into main (d125144) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main     #673   +/-   ##
=========================================
  Coverage     63.66%   63.66%           
  Complexity     1380     1380           
=========================================
  Files           210      210           
  Lines          5648     5648           
  Branches        851      851           
=========================================
  Hits           3595     3595           
  Misses         1594     1594           
  Partials        459      459           
Files Coverage Δ
src/main/java/com/crowdin/cli/utils/Utils.java 53.85% <0.00%> (ø)

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddninja thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue welcomes contributions for Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies
3 participants