Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Localization gets stripped when it contains a plural form #34

Merged
merged 7 commits into from
Dec 22, 2023

Conversation

FlutterOd
Copy link
Collaborator

No description provided.

@FlutterOd FlutterOd changed the title Fixed issue "Localization gets stripped when it contains a plural form" fix: "Localization gets stripped when it contains a plural form" Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (93e2015) 54.03% compared to head (0636199) 53.91%.
Report is 1 commits behind head on main.

Files Patch % Lines
lib/src/crowdin_api.dart 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   54.03%   53.91%   -0.12%     
==========================================
  Files          13       13              
  Lines         385      397      +12     
==========================================
+ Hits          208      214       +6     
- Misses        177      183       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar linked an issue Dec 7, 2023 that may be closed by this pull request
@andrii-bodnar andrii-bodnar changed the title fix: "Localization gets stripped when it contains a plural form" fix: Localization gets stripped when it contains a plural form Dec 12, 2023
@mkobuolys
Copy link

Any plans to merge this and release a fix?

@andrii-bodnar
Copy link
Member

@mkobuolys, this PR is currently being tested by our QA team. It's expected to be released next week.

@andrii-bodnar andrii-bodnar merged commit c30421d into main Dec 22, 2023
8 checks passed
@andrii-bodnar andrii-bodnar deleted the bugfix/stripped_message_with_plural branch December 22, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization gets stripped when it contains a plural form
3 participants