-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configuration update with organization name #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MykhailoNester
commented
Sep 5, 2023
- move organizationName property to the CrowdinConfig with backward compatibility;
- deprecate usage in AuthConfig;
- add new check in config builder for organization name when hash matches enterprise project;
- documentation update;
…ompatibility; - deprecate usage in AuthConfig; - add new check in config builder for organization name when hash matches enterprise project; - documentation update;
MykhailoNester
force-pushed
the
bug/enterprise_languages
branch
from
September 5, 2023 11:54
3bbce8c
to
a1e6938
Compare
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
============================================
+ Coverage 59.48% 59.54% +0.07%
- Complexity 359 364 +5
============================================
Files 56 56
Lines 1816 1841 +25
Branches 297 298 +1
============================================
+ Hits 1080 1096 +16
- Misses 535 542 +7
- Partials 201 203 +2
|
- documentation update;
andrii-bodnar
approved these changes
Sep 6, 2023
andrii-bodnar
changed the title
Configuration update with organization name.
feat: configuration update with organization name
Sep 6, 2023
andrii-bodnar
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.