Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configuration update with organization name #217

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

MykhailoNester
Copy link
Collaborator

  • move organizationName property to the CrowdinConfig with backward compatibility;
  • deprecate usage in AuthConfig;
  • add new check in config builder for organization name when hash matches enterprise project;
  • documentation update;

…ompatibility;

- deprecate usage in AuthConfig;
- add new check in config builder for organization name when hash matches enterprise project;
- documentation update;
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #217 (8c2833b) into master (af18a80) will increase coverage by 0.07%.
The diff coverage is 64.52%.

@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
+ Coverage     59.48%   59.54%   +0.07%     
- Complexity      359      364       +5     
============================================
  Files            56       56              
  Lines          1816     1841      +25     
  Branches        297      298       +1     
============================================
+ Hits           1080     1096      +16     
- Misses          535      542       +7     
- Partials        201      203       +2     
Files Changed Coverage Δ
...wdin/src/main/java/com/crowdin/platform/Crowdin.kt 19.61% <0.00%> (-0.09%) ⬇️
...rc/main/java/com/crowdin/platform/CrowdinConfig.kt 82.86% <18.19%> (-12.05%) ⬇️
.../src/main/java/com/crowdin/platform/SessionImpl.kt 78.27% <100.00%> (+3.27%) ⬆️
...java/com/crowdin/platform/data/model/AuthConfig.kt 100.00% <100.00%> (ø)
...form/data/remote/interceptor/SessionInterceptor.kt 82.76% <100.00%> (ø)

- documentation update;
@andrii-bodnar andrii-bodnar changed the title Configuration update with organization name. feat: configuration update with organization name Sep 6, 2023
@andrii-bodnar andrii-bodnar merged commit 744634b into master Sep 12, 2023
5 checks passed
@andrii-bodnar andrii-bodnar deleted the bug/enterprise_languages branch September 12, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crowdin over-the-air not working with default variant of spanish language
2 participants