Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Xcstrings #276

Merged
merged 6 commits into from
Apr 30, 2024
Merged

feat: Xcstrings #276

merged 6 commits into from
Apr 30, 2024

Conversation

serhii-londar
Copy link
Collaborator

@serhii-londar serhii-londar commented Apr 6, 2024

Closes #271

@crowdin-bot
Copy link
Collaborator

crowdin-bot commented Apr 6, 2024

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Swift against 73c0410

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 17.24138% with 120 lines in your changes are missing coverage. Please review.

Project coverage is 58.10%. Comparing base (b064507) to head (7bcd7e0).
Report is 5 commits behind head on master.

❗ Current head 7bcd7e0 differs from pull request most recent head 73c0410. Consider uploading reports for the commit 73c0410 to get more accurate results

Files Patch % Lines
...Operations/CrowdinXcstringsDownloadOperation.swift 0.00% 88 Missing ⚠️
...tionDownloader/CrowdinLocalizationDownloader.swift 25.00% 12 Missing ⚠️
...owdinSDK/CrowdinFileSystem/ReadWriteProtocol.swift 0.00% 9 Missing ⚠️
...ContentDeliveryAPI/CrowdinContentDeliveryAPI.swift 0.00% 7 Missing ⚠️
...ers/Crowdin/CrowdinRemoteLocalizationStorage.swift 33.34% 2 Missing ⚠️
...wdin/MappingDownloader/CrowdinMappingManager.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   59.50%   58.10%   -1.40%     
==========================================
  Files         121      122       +1     
  Lines        4422     4551     +129     
==========================================
+ Hits         2631     2644      +13     
- Misses       1791     1907     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@serhii-londar serhii-londar merged commit 09ed0de into master Apr 30, 2024
5 of 7 checks passed
@serhii-londar serhii-londar deleted the xcstrings branch April 30, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.xcstrings files support
3 participants