fix: add missing languages and correctly find languageCode #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImRodry
changed the title
|
The last commit is a fix to projects with files hidden to certain languages, which simply catches the request and makes it fall back to null so it can later be removed from getLanguageTranslations |
yevheniyJ
reviewed
Jan 29, 2022
yevheniyJ
reviewed
Jan 29, 2022
yevheniyJ
reviewed
Jan 29, 2022
|
I committed that fix a while ago but for some reason github didn’t pick up, so I force-pushed |
yevheniyJ
reviewed
Jan 29, 2022
|
Looks good. Just a minor comment. I will merged and release new version tomorrow and also will bump the axios library |
|
Done. Please use the squash and merge option when you merge since we got a few commits here :P |
|
BTW I plan on opening a second PR to fix a few performance issues and other minor improvements, if you wanna wait a few hours for that, otherwise feel free to merge and release and that can come later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing languages that were recently added to Crowdin (obtained through
/languageson the API) and also fixes the find function to look for the osxLocale instead of the twoLettersCode, as this code is often repeated in some languages and caused them to be incorrectly retrieved. These changes were tested and confirmed to work. There is one issue left, which is that, for files that are only available to specific languages, the client will throw an error as it cannot fetch the endpoint. I can fix this by removing these files from the final array, let me know if you'd like that fix or a different approach, as the CDN currently does not tell us which files are available in what languages beforehand.