Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add methods for replacing placeholders #31

Merged
merged 2 commits into from
Feb 8, 2022
Merged

feat: add methods for replacing placeholders #31

merged 2 commits into from
Feb 8, 2022

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Feb 5, 2022

This PR adds 3 new methods to the library to make it easier to retrieve raw data such as replaced URLs, full language objects and language codes in a specific format. Tests for all methods were added and are passing, but if you think there are better ways to implement these methods, please let me know!

@andrii-bodnar
Copy link
Member

Hi @ImRodry, thanks a lot for your contribution!

Copy link
Collaborator

@yevheniyJ yevheniyJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! But could you please add those new methods to the README?

@ImRodry
Copy link
Contributor Author

ImRodry commented Feb 7, 2022

Absolutely! I thought of that but it completely slipped my mind in the end. Will do now

@yevheniyJ yevheniyJ merged commit 442a9c2 into crowdin:main Feb 8, 2022
@ImRodry ImRodry deleted the feat-util-replace-methods branch February 8, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants