refactor: fetch languages from Crowdin API #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevheniyJ
reviewed
Feb 10, 2022
yevheniyJ
reviewed
Feb 10, 2022
yevheniyJ
reviewed
Feb 10, 2022
|
All requests have been addressed, could you re-review? I also made sure to test a bunch of scenarios and I can confirm the languages API is only fetched once with cache enabled! |
|
Thanks! Will take a look later on. Probably will release it this weekend. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded languages array from exportPattern.ts and fetches them once they're used and caches them (if cache isn't disabled). Resolves #32