Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer_review with one response #12

Closed
dmorina opened this issue Sep 1, 2016 · 4 comments
Closed

peer_review with one response #12

dmorina opened this issue Sep 1, 2016 · 4 comments

Comments

@dmorina
Copy link
Member

dmorina commented Sep 1, 2016

there is an initialization problem with peer review when only one response is streamed (either when stream=True or when there only one worker doing only one task)

@shirishgoyal
Copy link
Contributor

Should we error out if it has single response ?

@mbernst
Copy link

mbernst commented Sep 14, 2016

What did we decide here? I thought it was an error if not including history

On Tue, Sep 13, 2016 at 6:02 PM, Shirish Goyal notifications@github.com
wrote:

Should we error out if it has single response ?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPNxWyMAnHEYIjhUcfBxLa8VzZCaPyJks5qp0eigaJpZM4Jy-II
.

@dmorina
Copy link
Member Author

dmorina commented Sep 14, 2016

yeah, or when we add caching of these responses just notify them but not error

@shirishgoyal
Copy link
Contributor

Closed in #28
Error will be shown if
a) one response is pushed
b) responses from same worker are pushed as inter_task_review is disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants