Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppSec] Add real http request to hooks #2701

Closed
LaurenceJJones opened this issue Jan 5, 2024 · 3 comments
Closed

[AppSec] Add real http request to hooks #2701

LaurenceJJones opened this issue Jan 5, 2024 · 3 comments
Assignees
Labels
kind/enhancement New feature or request needs/triage

Comments

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Jan 5, 2024

What would you like to be added?

I want to be able to access the http request from pre_eval, on_match etc. Currently we're exposing our own "ParsedHTTPRequest" that is not very convenient.

Why is this needed?

A user may want to filter by a request variable for example I want to remove a rule by ID based on a subdomain I have

pre_eval:
  - filter: "req.Host == 'mydomain.com'"
    apply:
      - RemoveInBandRuleByID(1234)
Copy link

github-actions bot commented Jan 5, 2024

@LaurenceJJones: Thanks for opening an issue, it is currently awaiting triage.

In the meantime, you can:

  1. Check Crowdsec Documentation to see if your issue can be self resolved.
  2. You can also join our Discord.
  3. Check Releases to make sure your agent is on the latest version.
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jan 5, 2024

@LaurenceJJones: There are no 'kind' label on this issue. You need a 'kind' label to start the triage process.

  • /kind feature
  • /kind enhancement
  • /kind bug
  • /kind packaging
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones LaurenceJJones changed the title [AppSec] Add req (request) to pre and post eval hooks [AppSec] Add req (request) to pre eval hooks Jan 5, 2024
@LaurenceJJones LaurenceJJones added kind/enhancement New feature or request and removed needs/kind labels Jan 5, 2024
@buixor buixor changed the title [AppSec] Add req (request) to pre eval hooks [AppSec] Add real http request to hooks Jan 15, 2024
@buixor
Copy link
Contributor

buixor commented Jan 17, 2024

fixed by #2740

@buixor buixor closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/triage
Projects
None yet
Development

No branches or pull requests

3 participants