New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add original http request to hooks #2740
Conversation
@AlteredCoder: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@AlteredCoder: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2740 +/- ##
==========================================
+ Coverage 48.56% 49.82% +1.25%
==========================================
Files 130 160 +30
Lines 16952 20577 +3625
==========================================
+ Hits 8233 10252 +2019
- Misses 7835 9304 +1469
- Partials 884 1021 +137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/kind enhancement |
/area agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original request needs to be modified to match the incoming x-crowdsec
headers or else r.Host
will be the AppSec
server hostname instead of the actual requested hostname
of the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add original http request to pre_eval, onmatch and post_eval.