Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original http request to hooks #2740

Merged
merged 3 commits into from Jan 16, 2024
Merged

Conversation

AlteredCoder
Copy link
Contributor

@AlteredCoder AlteredCoder commented Jan 15, 2024

Add original http request to pre_eval, onmatch and post_eval.

Copy link

@AlteredCoder: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@AlteredCoder: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (03bb194) 48.56% compared to head (b5f7273) 49.82%.
Report is 5 commits behind head on master.

❗ Current head b5f7273 differs from pull request most recent head 3a5760b. Consider uploading reports for the commit 3a5760b to get more accurate results

Files Patch % Lines
pkg/appsec/request.go 0.00% 15 Missing ⚠️
pkg/appsec/waf_helpers.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2740      +/-   ##
==========================================
+ Coverage   48.56%   49.82%   +1.25%     
==========================================
  Files         130      160      +30     
  Lines       16952    20577    +3625     
==========================================
+ Hits         8233    10252    +2019     
- Misses       7835     9304    +1469     
- Partials      884     1021     +137     
Flag Coverage Δ
unit-linux 49.53% <0.00%> (?)
unit-windows 48.44% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlteredCoder
Copy link
Contributor Author

/kind enhancement

@AlteredCoder
Copy link
Contributor Author

/area agent

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original request needs to be modified to match the incoming x-crowdsec headers or else r.Host will be the AppSec server hostname instead of the actual requested hostnameof the server.

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlteredCoder AlteredCoder merged commit a65223a into master Jan 16, 2024
14 checks passed
@AlteredCoder AlteredCoder deleted the appsec_hook_http_request branch January 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants