Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #124 #127

Merged
merged 4 commits into from Jul 9, 2020
Merged

fix #124 #127

merged 4 commits into from Jul 9, 2020

Conversation

erenJag
Copy link
Contributor

@erenJag erenJag commented Jul 8, 2020

fix #124

buixor
buixor requested changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor change

pkg/parser/node.go Outdated Show resolved Hide resolved
buixor
buixor approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erenJag erenJag merged commit 44304a3 into master Jul 9, 2020
@erenJag erenJag deleted the fix_#124 branch July 9, 2020 10:41
registergoofy pushed a commit that referenced this pull request Sep 7, 2020
@erenJag @registergoofy
fix #124 (#127)
fc231f5 
* fix #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buixor buixor buixor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug/crowdsec : in whitelist config, statics are applied even if the whitelist not succeed
2 participants
@erenJag @buixor