docker/README: automatic registration with tls (#1909) #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## releases/1.4.x #1919 +/- ##
==================================================
- Coverage 54.07% 53.53% -0.54%
==================================================
Files 148 148
Lines 19991 19991
==================================================
- Hits 10810 10703 -107
- Misses 7989 8111 +122
+ Partials 1192 1177 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sabban
reviewed
Dec 12, 2022
docker/README.md
Outdated
| @@ -163,13 +171,20 @@ https://docs.crowdsec.net/docs/user_guides/bouncers_configuration/ | |||
|
|
|||
| ### Automatic Bouncer Registration | |||
|
|
|||
| You can automatically register bouncers with the crowdsec container at startup, using environment variables or Docker secrets. You cannot use this process to update an existing bouncer without first deleting it. | |||
| Without TLS: | |||
There was a problem hiding this comment.
I would write TLs authentatication here, because one can have a tls lapi without having tls auth, hence the statement might be a bit misleading.
There was a problem hiding this comment.
ok! I'll change it in the master as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.