Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix/improve support for persistent configurations (#1915) #1922

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 11, 2022

  • set all defaults in config.yaml and leave environment variables empty. This way when they are set we know that we must override the values in config.yaml.
  • ignore tainted objects when calling install/upgrade/remove
  • use_wal is false by default

set all defaults in config.yaml and leave environment variables empty. This way when they are set we know that we must override the values in config.yaml.
ignore tainted objects when calling install/upgrade/remove
use_wal is false by default
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2022

Codecov Report

Merging #1922 (fb3eb76) into releases/1.4.x (f2528f3) will decrease coverage by 0.53%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           releases/1.4.x    #1922      +/-   ##
==================================================
- Coverage           54.07%   53.53%   -0.54%     
==================================================
  Files                 148      148              
  Lines               19991    19991              
==================================================
- Hits                10810    10703     -107     
- Misses               7989     8111     +122     
+ Partials             1192     1177      -15     
Flag Coverage Δ
func-crowdsec 45.40% <ø> (-10.27%) ⬇️
func-cscli 44.92% <ø> (ø)
unit-linux 58.01% <ø> (-0.04%) ⬇️
unit-windows 53.32% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec/serve.go 22.34% <0.00%> (-32.58%) ⬇️
cmd/crowdsec/api.go 51.85% <0.00%> (-27.78%) ⬇️
cmd/crowdsec/crowdsec.go 43.97% <0.00%> (-1.58%) ⬇️
cmd/crowdsec/main.go 62.94% <0.00%> (-1.02%) ⬇️
pkg/acquisition/modules/cloudwatch/cloudwatch.go 77.49% <0.00%> (-1.00%) ⬇️
pkg/leakybucket/manager_run.go 68.43% <0.00%> (+1.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc
Copy link
Contributor Author

mmetc commented Dec 12, 2022

/kind fix

@mmetc mmetc merged commit 86666f4 into releases/1.4.x Dec 12, 2022
@mmetc mmetc deleted the backport-docker-mounted-config branch December 12, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants