Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli hubtest whitelist #2479

Conversation

LaurenceJJones
Copy link
Contributor

Add whitelist properties to the gen parser assert function so when crowdsec pulls in the file it can actually check those properties.

ONLY TESTED ON s02-enrich parsers for now as those are the one we have in the hub

@github-actions
Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area agent

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2479 (c7c6542) into master (ac01faf) will decrease coverage by 0.08%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2479      +/-   ##
==========================================
- Coverage   56.56%   56.48%   -0.08%     
==========================================
  Files         189      189              
  Lines       26188    26192       +4     
==========================================
- Hits        14812    14795      -17     
- Misses       9771     9794      +23     
+ Partials     1605     1603       -2     
Flag Coverage Δ
bats 38.23% <0.00%> (-0.10%) ⬇️
unit-linux 54.82% <0.00%> (-0.04%) ⬇️
unit-windows 51.41% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/hubtest/parser_assert.go 36.20% <0.00%> (-0.38%) ⬇️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LaurenceJJones
Copy link
Contributor Author

Feedback from @buixor

We should always print if whitelist is false as we can check for the opposite (Should not be whitelisted and is ? have we messed up the function?)

@LaurenceJJones LaurenceJJones merged commit 37c0c06 into crowdsecurity:master Sep 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants