-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cscli hubtest whitelist #2479
cscli hubtest whitelist #2479
Conversation
@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind enhancement |
Codecov Report
@@ Coverage Diff @@
## master #2479 +/- ##
==========================================
- Coverage 56.56% 56.48% -0.08%
==========================================
Files 189 189
Lines 26188 26192 +4
==========================================
- Hits 14812 14795 -17
- Misses 9771 9794 +23
+ Partials 1605 1603 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Feedback from @buixor We should always print if whitelist is false as we can check for the opposite (Should not be whitelisted and is ? have we messed up the function?) |
Add whitelist properties to the gen parser assert function so when crowdsec pulls in the file it can actually check those properties.
ONLY TESTED ON s02-enrich parsers for now as those are the one we have in the hub