Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[postoverflow] dump after postoverflow so we can test within hubtest #2511

Merged

Conversation

LaurenceJJones
Copy link
Contributor

This is the first PR to allow some sort of postoverflow hubtests

Currently when the event is passed intobucketOverflows it is before the postoverflow meaning if the event does pass the postoverflow whitelist none of the properties are set within the dump file. Setting the append after postoverflows means hubtest can ingest this and test if the scenario is whitelist via expr

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones LaurenceJJones changed the title Add to dump after postoverflow so we can test within hubtest [postoverflow] dump after postoverflow so we can test within hubtest Oct 3, 2023
@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area agent

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (47eb2e2) 56.84% compared to head (8ce5219) 56.84%.

Files Patch % Lines
cmd/crowdsec/output.go 28.57% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2511   +/-   ##
=======================================
  Coverage   56.84%   56.84%           
=======================================
  Files         190      190           
  Lines       26156    26158    +2     
=======================================
+ Hits        14868    14870    +2     
  Misses       9732     9732           
  Partials     1556     1556           
Flag Coverage Δ
bats 38.54% <28.57%> (+<0.01%) ⬆️
unit-linux 55.20% <ø> (ø)
unit-windows 51.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit 05c1825 into crowdsecurity:master Nov 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants