"cscli bouncers add": increase key size, deprecate and ignore --length option #2531
Conversation
|
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2531 +/- ##
==========================================
+ Coverage 56.94% 57.00% +0.05%
==========================================
Files 195 195
Lines 26675 26674 -1
==========================================
+ Hits 15191 15205 +14
+ Misses 9901 9890 -11
+ Partials 1583 1579 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
we'll also deprecate / ignore the -l flag |
mmetc
force-pushed
the
bouncer-key-size
branch
from
994ba2d
to
fdc5bd3
Compare
mmetc
changed the title
mmetc
changed the title
mmetc
force-pushed
the
bouncer-key-size
branch
from
fdc5bd3
to
d3b9385
Compare
the switch to base64 made the keys shorter (24 characters), this PR increases their size to 32 bytes, 42 chars once encoded
Also deprecate the --length option, users can already provide a key