Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new env var to enable console_management #2599

Merged
merged 3 commits into from Dec 12, 2023

Conversation

he2ss
Copy link
Member

@he2ss he2ss commented Nov 16, 2023

No description provided.

Copy link

@he2ss: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@he2ss: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4bc225f) 56.30% compared to head (38a95b0) 57.01%.
Report is 97 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2599      +/-   ##
==========================================
+ Coverage   56.30%   57.01%   +0.71%     
==========================================
  Files         186      186              
  Lines       25806    25783      -23     
==========================================
+ Hits        14529    14701     +172     
+ Misses       9708     9538     -170     
+ Partials     1569     1544      -25     
Flag Coverage Δ
bats 38.82% <ø> (+1.05%) ⬆️
unit-linux 55.20% <ø> (+0.38%) ⬆️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@he2ss
Copy link
Member Author

he2ss commented Nov 16, 2023

/kind enhancement

@github-actions github-actions bot added kind/enhancement New feature or request and removed needs/kind labels Nov 16, 2023
@he2ss
Copy link
Member Author

he2ss commented Nov 16, 2023

/area configuration

docker/docker_start.sh Outdated Show resolved Hide resolved
Copy link
Member

@blotus blotus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after #2601 is merged

@buixor buixor added this to the 1.5.6 milestone Dec 8, 2023
@blotus blotus merged commit 4a4b309 into master Dec 12, 2023
14 checks passed
@blotus blotus deleted the docker/add_console_mgmt_param branch December 12, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants