Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refact pkg/cwhub: fix known issues and reorganize files #2616

Merged
merged 13 commits into from Nov 28, 2023
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 27, 2023

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (1aa4fc5) 58.16% compared to head (a1fc743) 58.22%.

Files Patch % Lines
pkg/cwhub/itemlink.go 38.46% 22 Missing and 10 partials ⚠️
pkg/cwhub/itemremove.go 67.81% 20 Missing and 8 partials ⚠️
pkg/cwhub/dataset.go 41.86% 20 Missing and 5 partials ⚠️
pkg/cwhub/hub.go 76.47% 8 Missing and 4 partials ⚠️
pkg/cwhub/iteminstall.go 79.54% 6 Missing and 3 partials ⚠️
pkg/cwhub/item.go 86.04% 4 Missing and 2 partials ⚠️
cmd/crowdsec-cli/utils.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2616      +/-   ##
==========================================
+ Coverage   58.16%   58.22%   +0.06%     
==========================================
  Files         199      201       +2     
  Lines       26925    26978      +53     
==========================================
+ Hits        15660    15709      +49     
- Misses       9723     9727       +4     
  Partials     1542     1542              
Flag Coverage Δ
bats 38.38% <66.56%> (+0.11%) ⬆️
unit-linux 55.31% <27.79%> (-0.14%) ⬇️
unit-windows 51.63% <27.79%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added the kind/enhancement New feature or request label Nov 27, 2023
@mmetc mmetc marked this pull request as ready for review November 28, 2023 11:02
@mmetc mmetc changed the title Refact cwhub Refact pkg/cwhub: fix known issues and reorganize files Nov 28, 2023
@mmetc mmetc requested a review from sabban November 28, 2023 11:03
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Still no separate counter for the --purge option, but should be clear enough
@mmetc mmetc merged commit 6b0bdc5 into master Nov 28, 2023
14 checks passed
@mmetc mmetc deleted the hub-1.5.6 branch November 28, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants