Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Pass down ctx and use it #2626

Conversation

LaurenceJJones
Copy link
Contributor

@LaurenceJJones LaurenceJJones commented Nov 29, 2023

Fix #2623

We didnt pass down cancelled context and updated plugins to use it but email does not have a way currently to use it.

It works as intended but we may want to update other plugins.

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind fix
/area agent

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7c5cbef) 58.18% compared to head (7df72d4) 58.21%.

Files Patch % Lines
cmd/notification-http/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2626      +/-   ##
==========================================
+ Coverage   58.18%   58.21%   +0.02%     
==========================================
  Files         201      201              
  Lines       27010    27010              
==========================================
+ Hits        15715    15723       +8     
+ Misses       9752     9745       -7     
+ Partials     1543     1542       -1     
Flag Coverage Δ
bats 38.36% <50.00%> (+0.07%) ⬆️
unit-linux 55.23% <100.00%> (ø)
unit-windows 51.58% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones changed the title [Plugin] Pass down ctx and http cancel [Plugin] Pass down ctx and use it Nov 29, 2023
@sabban sabban requested a review from blotus December 4, 2023 09:17
@LaurenceJJones LaurenceJJones merged commit d1bfadd into crowdsecurity:master Dec 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Plugin] HTTP notification should use context
2 participants