Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http plugin] Add capath, certpath, keypath to load custom certs #2634

Merged

Conversation

LaurenceJJones
Copy link
Contributor

Implement #2142

I can replicate these changes across to other plugins that use http base stuff, However, I wanted to draft a PR to ask should we include the helpers function in go-cs-lib as then we can have a central place tag @mmetc

Copy link

github-actions bot commented Dec 4, 2023

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Dec 4, 2023

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones LaurenceJJones changed the title [http plugin] Add cacert, certpath, certkey to http plugin to load custom cetificates [http plugin] Add cacert, certpath, certkey to http plugin to load custom certs Dec 4, 2023
@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area agent

@LaurenceJJones LaurenceJJones changed the title [http plugin] Add cacert, certpath, certkey to http plugin to load custom certs [http plugin] Add capath, certpath, certkey to http plugin to load custom certs Dec 4, 2023
@LaurenceJJones LaurenceJJones changed the title [http plugin] Add capath, certpath, certkey to http plugin to load custom certs [http plugin] Add capath, certpath, keypath to http plugin to load custom certs Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (acd2a14) 55.01% compared to head (0aa659a) 55.04%.

Files Patch % Lines
cmd/notification-http/main.go 0.00% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2634      +/-   ##
==========================================
+ Coverage   55.01%   55.04%   +0.02%     
==========================================
  Files         220      224       +4     
  Lines       29421    29841     +420     
==========================================
+ Hits        16187    16425     +238     
- Misses      11663    11811     +148     
- Partials     1571     1605      +34     
Flag Coverage Δ
bats 36.41% <0.00%> (-0.11%) ⬇️
unit-linux 49.64% <ø> (+<0.01%) ⬆️
unit-windows 47.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc
Copy link
Contributor

mmetc commented Dec 7, 2023

Mmmh.. I think the function is simple and idiomatic enough that it doesn't justify the added dependency.

@LaurenceJJones LaurenceJJones marked this pull request as ready for review December 11, 2023 14:45
@LaurenceJJones LaurenceJJones changed the title [http plugin] Add capath, certpath, keypath to http plugin to load custom certs [http plugin] Add capath, certpath, keypath to load custom certs Dec 11, 2023
@LaurenceJJones LaurenceJJones merged commit b1c9717 into crowdsecurity:master Dec 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants