Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli refact / encapsulation #2650

Merged
merged 7 commits into from Dec 11, 2023
Merged

cscli refact / encapsulation #2650

merged 7 commits into from Dec 11, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 8, 2023

No description provided.

Copy link

github-actions bot commented Dec 8, 2023

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Dec 8, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc requested a review from sabban December 8, 2023 17:18
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b4ec66) 47.74% compared to head (35f984f) 47.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2650   +/-   ##
=======================================
  Coverage   47.74%   47.74%           
=======================================
  Files         130      130           
  Lines       16901    16901           
=======================================
  Hits         8070     8070           
  Misses       7947     7947           
  Partials      884      884           
Flag Coverage Δ
unit-windows 47.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added the kind/enhancement New feature or request label Dec 8, 2023
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit c10aad7 into master Dec 11, 2023
14 checks passed
@mmetc mmetc deleted the cscli-types branch December 11, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants