Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package tests for 1.5.6-rc2 #2652

Merged
merged 4 commits into from Dec 11, 2023
Merged

fix package tests for 1.5.6-rc2 #2652

merged 4 commits into from Dec 11, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 9, 2023

No description provided.

Copy link

github-actions bot commented Dec 9, 2023

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Dec 9, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc removed the request for review from sabban December 9, 2023 23:45
@mmetc mmetc marked this pull request as draft December 9, 2023 23:45
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04f3dc0) 54.90% compared to head (c4bff6c) 54.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
+ Coverage   54.90%   54.93%   +0.03%     
==========================================
  Files         224      224              
  Lines       29779    29779              
==========================================
+ Hits        16350    16359       +9     
+ Misses      11835    11830       -5     
+ Partials     1594     1590       -4     
Flag Coverage Δ
bats 36.32% <ø> (+0.04%) ⬆️
unit-linux 49.63% <ø> (+<0.01%) ⬆️
unit-windows 47.73% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from sabban December 11, 2023 08:31
@mmetc mmetc marked this pull request as ready for review December 11, 2023 08:31
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 1b4ec66 into master Dec 11, 2023
14 checks passed
@mmetc mmetc deleted the 1.5.6-tests branch December 11, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants