Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli machines: lint + write output to stdout instead of log #2657

Merged
merged 13 commits into from Dec 13, 2023
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 13, 2023

this allows us to run it with --error in the postinst scripts and avoid duplicate warnings about wal, capi etc.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6eabb46) 55.10% compared to head (99d3ec0) 55.09%.

Files Patch % Lines
cmd/crowdsec-cli/machines.go 57.14% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2657      +/-   ##
==========================================
- Coverage   55.10%   55.09%   -0.02%     
==========================================
  Files         224      224              
  Lines       29841    29840       -1     
==========================================
- Hits        16445    16439       -6     
- Misses      11783    11791       +8     
+ Partials     1613     1610       -3     
Flag Coverage Δ
bats 36.53% <57.14%> (-0.03%) ⬇️
unit-linux 49.63% <ø> (+<0.01%) ⬆️
unit-windows 47.73% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added the kind/enhancement New feature or request label Dec 13, 2023
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 12d9fba into master Dec 13, 2023
14 checks passed
@mmetc mmetc deleted the 1.5.6-mm branch December 13, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants