Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to run hubtest for appsec in docker #2660

Merged
merged 5 commits into from Dec 14, 2023
Merged

Conversation

AlteredCoder
Copy link
Contributor

  • Allow to pass "--target" argument for hubtest run, to specify the target for appsec tests
  • Small fix in crowdsec docker (to execute /docker_start.sh and not docker_start.sh)

Copy link

@AlteredCoder: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@AlteredCoder: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (67cdf91) 54.79% compared to head (0521b8d) 55.29%.
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/hubtest/hubtest_item.go 0.00% 10 Missing ⚠️
pkg/appsec/request.go 0.00% 5 Missing ⚠️
pkg/hubtest/nucleirunner.go 0.00% 3 Missing ⚠️
cmd/crowdsec-cli/hubtest.go 66.66% 2 Missing ⚠️
pkg/hubtest/hubtest.go 0.00% 2 Missing ⚠️
pkg/hubtest/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2660      +/-   ##
==========================================
+ Coverage   54.79%   55.29%   +0.49%     
==========================================
  Files         227      227              
  Lines       29899    30034     +135     
==========================================
+ Hits        16384    16608     +224     
+ Misses      11920    11818     -102     
- Partials     1595     1608      +13     
Flag Coverage Δ
bats 36.74% <14.81%> (+0.52%) ⬆️
unit-linux 49.66% <0.00%> (+0.07%) ⬆️
unit-windows 47.85% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit a941576 into master Dec 14, 2023
13 of 14 checks passed
@blotus blotus deleted the hubtest_appsec_fix branch December 14, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants