Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used asterisk for Defender Firewall log name #2671

Merged
merged 1 commit into from Dec 20, 2023
Merged

Used asterisk for Defender Firewall log name #2671

merged 1 commit into from Dec 20, 2023

Conversation

zbalkan
Copy link
Contributor

@zbalkan zbalkan commented Dec 19, 2023

Log name is configurable. MS Docs recommend a log file per profile:

For each profile (Domain, Private, and Public) change the default log file name from %windir%\system32\logfiles\firewall\pfirewall.log to:
- %windir%\system32\logfiles\firewall\pfirewall_Domain.log
- %windir%\system32\logfiles\firewall\pfirewall_Private.log
- %windir%\system32\logfiles\firewall\pfirewall_Public.log

Current configuration misses these files if the user implements best practices.

Copy link

@zbalkan: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@zbalkan: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0e9e3e) 55.21% compared to head (1efecf2) 55.21%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2671   +/-   ##
=======================================
  Coverage   55.21%   55.21%           
=======================================
  Files         227      227           
  Lines       30198    30198           
=======================================
  Hits        16674    16674           
  Misses      11908    11908           
  Partials     1616     1616           
Flag Coverage Δ
bats 36.76% <ø> (+<0.01%) ⬆️
unit-linux 49.69% <ø> (ø)
unit-windows 47.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus
Copy link
Member

blotus commented Dec 20, 2023

Thank you!

@blotus blotus merged commit e1932ff into crowdsecurity:master Dec 20, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants