Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bump golangci-lint run to 1.55, update defaults #2677

Merged
merged 1 commit into from Dec 21, 2023
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 21, 2023

The plan is to enable linters first, then fix issues types one by one.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added the kind/enhancement New feature or request label Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33e3fda) 55.08% compared to head (33a75bc) 55.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2677      +/-   ##
==========================================
+ Coverage   55.08%   55.11%   +0.02%     
==========================================
  Files         227      227              
  Lines       30267    30267              
==========================================
+ Hits        16674    16683       +9     
+ Misses      11975    11969       -6     
+ Partials     1618     1615       -3     
Flag Coverage Δ
bats 36.67% <ø> (+0.02%) ⬆️
unit-linux 49.70% <ø> (ø)
unit-windows 47.86% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the lint-defaults branch 2 times, most recently from 9ca6799 to b359a88 Compare December 21, 2023 11:02
@mmetc mmetc marked this pull request as ready for review December 21, 2023 11:02
The plan is to enable linters first, then fix issues types one by one.
@mmetc mmetc changed the title Bump golangci-lint run to 1.55, update defaults CI: bump golangci-lint run to 1.55, update defaults Dec 21, 2023
@mmetc mmetc requested a review from blotus December 21, 2023 11:06
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 162768b into master Dec 21, 2023
16 checks passed
@mmetc mmetc deleted the lint-defaults branch December 21, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants