Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notifications] Fix bug, list show non active #2678

Merged

Conversation

LaurenceJJones
Copy link
Contributor

No description provided.

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/enhancement
/area cscli

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement

@github-actions github-actions bot added kind/enhancement New feature or request and removed needs/kind labels Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (e1932ff) 55.23% compared to head (167792a) 55.27%.

Files Patch % Lines
cmd/crowdsec-cli/notifications.go 33.33% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2678      +/-   ##
==========================================
+ Coverage   55.23%   55.27%   +0.04%     
==========================================
  Files         227      227              
  Lines       30206    30203       -3     
==========================================
+ Hits        16685    16696      +11     
+ Misses      11906    11893      -13     
+ Partials     1615     1614       -1     
Flag Coverage Δ
bats 36.79% <68.75%> (+<0.01%) ⬆️
unit-linux 49.70% <ø> (+<0.01%) ⬆️
unit-windows 47.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit 2212c2f into crowdsecurity:master Dec 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants