New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parser/scenarios] defer yaml file closure #2689
Conversation
@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind enhancement |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2689 +/- ##
==========================================
+ Coverage 55.08% 55.12% +0.04%
==========================================
Files 227 227
Lines 30360 30363 +3
==========================================
+ Hits 16724 16739 +15
+ Misses 12015 12006 -9
+ Partials 1621 1618 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Whilst debugging an issue I saw we kept the FD's of parsers and scenario open even after being fully loaded. Turns out we never explicitly defer the func so this adds it