Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parser/scenarios] defer yaml file closure #2689

Merged
merged 4 commits into from Jan 17, 2024

Conversation

LaurenceJJones
Copy link
Contributor

@LaurenceJJones LaurenceJJones commented Dec 29, 2023

Whilst debugging an issue I saw we kept the FD's of parsers and scenario open even after being fully loaded. Turns out we never explicitly defer the func so this adds it

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area agent

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f306d59) 55.08% compared to head (cdfe09f) 55.12%.

Files Patch % Lines
pkg/parser/stage.go 33.33% 2 Missing ⚠️
pkg/leakybucket/manager_load.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
+ Coverage   55.08%   55.12%   +0.04%     
==========================================
  Files         227      227              
  Lines       30360    30363       +3     
==========================================
+ Hits        16724    16739      +15     
+ Misses      12015    12006       -9     
+ Partials     1621     1618       -3     
Flag Coverage Δ
bats 36.74% <40.00%> (+0.03%) ⬆️
unit-linux 49.72% <40.00%> (+0.05%) ⬆️
unit-windows 47.88% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added this to the 1.5.6 milestone Jan 12, 2024
@buixor buixor merged commit 4df4e5b into crowdsecurity:master Jan 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants