Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appsec] implement count transformation #2698

Merged
merged 5 commits into from Jan 12, 2024
Merged

[appsec] implement count transformation #2698

merged 5 commits into from Jan 12, 2024

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Jan 5, 2024

the count transformation transform a selection into the number of items

Copy link

github-actions bot commented Jan 5, 2024

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jan 5, 2024

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa4f02c) 55.15% compared to head (16de289) 55.18%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2698      +/-   ##
==========================================
+ Coverage   55.15%   55.18%   +0.02%     
==========================================
  Files         227      227              
  Lines       30388    30401      +13     
==========================================
+ Hits        16760    16776      +16     
+ Misses      12011    12009       -2     
+ Partials     1617     1616       -1     
Flag Coverage Δ
bats 36.84% <0.00%> (+0.03%) ⬆️
unit-linux 49.71% <100.00%> (+0.03%) ⬆️
unit-windows 47.90% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor
Copy link
Contributor Author

buixor commented Jan 5, 2024

/area agent
/kind enhancement

@buixor buixor changed the title appsec: implement count transformation [appsec] implement count transformation Jan 11, 2024
@buixor buixor marked this pull request as ready for review January 11, 2024 17:04
Copy link
Member

@blotus blotus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add some tests :)

@buixor buixor merged commit 896dfef into master Jan 12, 2024
16 checks passed
@buixor buixor deleted the appsec_count branch January 12, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants