Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: use GO macro if set, to check for version #2706

Merged
merged 1 commit into from Jan 11, 2024
Merged

Makefile: use GO macro if set, to check for version #2706

merged 1 commit into from Jan 11, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 8, 2024 •
edited

required for example when GO=go121

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.5.6 milestone Jan 9, 2024
sabban
sabban approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit a59ae61 into master Jan 11, 2024
15 checks passed
@mmetc mmetc deleted the gocmd branch January 11, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabban sabban sabban approved these changes

Assignees
No one assigned
Labels
kind/chore needs/area
Projects
None yet
Milestone
1.5.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmetc @sabban