Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cwhub: improve error messages #2712

Merged
merged 3 commits into from Jan 11, 2024
Merged

pkg/cwhub: improve error messages #2712

merged 3 commits into from Jan 11, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 9, 2024

less verbose + handle the case where latest version is missing

Copy link

github-actions bot commented Jan 9, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jan 9, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added the kind/enhancement New feature or request label Jan 9, 2024
@mmetc mmetc added this to the 1.5.6 milestone Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f306d59) 55.08% compared to head (6d6b8c1) 55.16%.
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/cwhub/itemupgrade.go 50.00% 5 Missing and 1 partial ⚠️
cmd/crowdsec-cli/hubappsec.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2712      +/-   ##
==========================================
+ Coverage   55.08%   55.16%   +0.07%     
==========================================
  Files         227      227              
  Lines       30360    30388      +28     
==========================================
+ Hits        16724    16763      +39     
+ Misses      12015    12009       -6     
+ Partials     1621     1616       -5     
Flag Coverage Δ
bats 36.74% <70.37%> (+0.04%) ⬆️
unit-linux 49.68% <24.00%> (+<0.01%) ⬆️
unit-windows 47.88% <24.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 260f5a7 into master Jan 11, 2024
16 checks passed
@mmetc mmetc deleted the cwhub-index-errors branch January 11, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants