Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log death reason of file reader if available #2721

Merged
merged 1 commit into from Jan 15, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Jan 11, 2024

Closes #2718

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Jan 11, 2024

/kind fix
/area agent

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0f72291) 55.00% compared to head (573d9fc) 55.11%.

Files Patch % Lines
pkg/acquisition/modules/file/file.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2721      +/-   ##
==========================================
+ Coverage   55.00%   55.11%   +0.11%     
==========================================
  Files         223      227       +4     
  Lines       29996    30374     +378     
==========================================
+ Hits        16498    16742     +244     
- Misses      11913    12014     +101     
- Partials     1585     1618      +33     
Flag Coverage Δ
bats 36.73% <0.00%> (-0.03%) ⬇️
unit-linux 49.68% <0.00%> (+<0.01%) ⬆️
unit-windows 47.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit fd30913 into master Jan 15, 2024
16 checks passed
@blotus blotus deleted the file-acquis-log-death-reason branch January 15, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[File] Log the underlying reason for dead reader
2 participants