Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cpu-profile flag #2723

Merged
merged 8 commits into from Jan 16, 2024
Merged

add cpu-profile flag #2723

merged 8 commits into from Jan 16, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Jan 11, 2024

Add a cpu-profile flag to make crowdsec generate a CPU profile by itself (without querying the pprof HTTP endpoint).

Closes #2715

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Jan 11, 2024

/kind enhancement

@github-actions github-actions bot added kind/enhancement New feature or request and removed needs/kind labels Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (24b5e8f) 55.18% compared to head (9cea08d) 55.16%.

Files Patch % Lines
cmd/crowdsec/main.go 20.00% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2723      +/-   ##
==========================================
- Coverage   55.18%   55.16%   -0.02%     
==========================================
  Files         230      230              
  Lines       30520    30542      +22     
==========================================
+ Hits        16842    16850       +8     
- Misses      12064    12077      +13     
- Partials     1614     1615       +1     
Flag Coverage Δ
bats 36.88% <47.82%> (-0.02%) ⬇️
unit-linux 49.57% <ø> (+<0.01%) ⬆️
unit-windows 48.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/crowdsec/main.go Dismissed Show dismissed Hide dismissed
@blotus blotus merged commit 421ef3b into master Jan 16, 2024
16 checks passed
@blotus blotus deleted the add-cpuprofile-flag branch January 16, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose flag for CPU profiling
2 participants