Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiclient/apiserver: lint #2739

Merged
merged 1 commit into from Jan 15, 2024
Merged

apiclient/apiserver: lint #2739

merged 1 commit into from Jan 15, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 15, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc requested a review from sabban January 15, 2024 09:30
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (03bb194) 48.56% compared to head (b0bd6e6) 55.11%.

Files Patch % Lines
pkg/apiserver/controllers/v1/decisions.go 29.16% 17 Missing ⚠️
pkg/apiclient/decisions_sync_service.go 0.00% 4 Missing ⚠️
pkg/apiserver/middlewares/v1/api_key.go 33.33% 4 Missing ⚠️
pkg/apiclient/auth.go 77.77% 2 Missing ⚠️
pkg/apiclient/decisions_service.go 88.23% 2 Missing ⚠️
pkg/apiclient/heartbeat.go 0.00% 2 Missing ⚠️
pkg/apiserver/controllers/v1/alerts.go 81.81% 2 Missing ⚠️
pkg/apiserver/apic.go 75.00% 0 Missing and 1 partial ⚠️
pkg/apiserver/middlewares/v1/jwt.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2739      +/-   ##
==========================================
+ Coverage   48.56%   55.11%   +6.55%     
==========================================
  Files         130      226      +96     
  Lines       16952    30088   +13136     
==========================================
+ Hits         8233    16584    +8351     
- Misses       7835    11924    +4089     
- Partials      884     1580     +696     
Flag Coverage Δ
bats 36.88% <50.00%> (?)
unit-linux 49.68% <59.25%> (?)
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 75d8ad9 into master Jan 15, 2024
16 checks passed
@mmetc mmetc deleted the api-lint branch January 15, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants