Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the reload process for appsec #2750

Merged
merged 1 commit into from Jan 17, 2024
Merged

fix the reload process for appsec #2750

merged 1 commit into from Jan 17, 2024

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Jan 17, 2024

No description provided.

@buixor buixor marked this pull request as ready for review January 17, 2024 10:11
Copy link

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f156f17) 57.09% compared to head (e5466d5) 57.04%.

Files Patch % Lines
pkg/acquisition/modules/appsec/appsec.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2750      +/-   ##
==========================================
- Coverage   57.09%   57.04%   -0.05%     
==========================================
  Files         230      230              
  Lines       30553    30556       +3     
==========================================
- Hits        17444    17432      -12     
- Misses      11431    11441      +10     
- Partials     1678     1683       +5     
Flag Coverage Δ
bats 36.75% <33.33%> (-0.17%) ⬇️
unit-linux 52.43% <0.00%> (-0.02%) ⬇️
unit-windows 47.99% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor
Copy link
Contributor Author

buixor commented Jan 17, 2024

/area agent
/kind fix

@buixor buixor merged commit 685cda5 into master Jan 17, 2024
15 of 16 checks passed
@buixor buixor deleted the fix_appsec_reload branch January 17, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants