Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-install: reduce verbosity #2751

Merged
merged 6 commits into from Jan 18, 2024
Merged

post-install: reduce verbosity #2751

merged 6 commits into from Jan 18, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 17, 2024

this removes the initial WAL warning too, is that ok or should I put it back?

Otherwise, we don't see anymore:

find: '/usr/local/openresty/nginx/logs': No such file or directory
...
WARN[2024-01-17T11:24:37Z] can't load CAPI credentials from '/etc/crowdsec/online_api_credentials.yaml' (missing login field)
INFO[2024-01-17T11:24:37Z] push and pull to Central API disabled       

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added the kind/enhancement New feature or request label Jan 17, 2024
@mmetc mmetc marked this pull request as ready for review January 17, 2024 12:07
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4df4e5b) 57.07% compared to head (ad13e09) 57.04%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2751      +/-   ##
==========================================
- Coverage   57.07%   57.04%   -0.03%     
==========================================
  Files         230      233       +3     
  Lines       30559    30559              
==========================================
- Hits        17441    17433       -8     
- Misses      11437    11443       +6     
- Partials     1681     1683       +2     
Flag Coverage Δ
bats 36.84% <ø> (-0.07%) ⬇️
unit-linux 52.36% <ø> (-0.09%) ⬇️
unit-windows 47.89% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit fa8d5b6 into master Jan 18, 2024
16 checks passed
@mmetc mmetc deleted the install-verbosity branch January 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants