pkg/hubtest: extract methods + consistent error handling

[mmetc]

• extract methods from loops to increase maintainability
• treat errors in the same way for all item types

[github-actions]

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

Attention: 170 lines in your changes are missing coverage. Please review.

Comparison is base (45571ce) 57.86% compared to head (a004097) 57.92%.

Files	Patch %	Lines
pkg/hubtest/parser.go	0.00%	48 Missing ⚠️
pkg/hubtest/postoverflow.go	0.00%	47 Missing ⚠️
pkg/hubtest/appsecrule.go	0.00%	38 Missing ⚠️
pkg/hubtest/scenario.go	0.00%	37 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2756      +/-   ##
==========================================
+ Coverage   57.86%   57.92%   +0.06%     
==========================================
  Files         235      239       +4     
  Lines       30576    30971     +395     
==========================================
+ Hits        17693    17941     +248     
- Misses      11287    11401     +114     
- Partials     1596     1629      +33     

Flag	Coverage Δ
bats	37.87% <0.00%> (-0.04%)	⬇️
unit-linux	52.34% <0.00%> (-0.04%)	⬇️
unit-windows	47.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sabban]

lgtm