Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some tests #2775

Merged
merged 1 commit into from Jan 24, 2024
Merged

fix some tests #2775

merged 1 commit into from Jan 24, 2024

Conversation

sabban
Copy link
Contributor

@sabban sabban commented Jan 23, 2024

  • avoid the "//" occurence
  • Avoid the Group configuration that fails on centos

Copy link

@sabban: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@sabban: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@sabban sabban requested a review from mmetc January 23, 2024 17:51
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce32fc0) 56.96% compared to head (0d8da42) 56.77%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2775      +/-   ##
==========================================
- Coverage   56.96%   56.77%   -0.19%     
==========================================
  Files         237      233       -4     
  Lines       30594    30268     -326     
==========================================
- Hits        17428    17186     -242     
+ Misses      11480    11429      -51     
+ Partials     1686     1653      -33     
Flag Coverage Δ
bats 36.68% <ø> (-0.09%) ⬇️
unit-linux 52.24% <ø> (-0.02%) ⬇️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sabban
Copy link
Contributor Author

sabban commented Jan 24, 2024

/kind fix
/area tests

@mmetc mmetc added this to the 1.6.1 milestone Jan 24, 2024
@sabban sabban merged commit 3f9e8e8 into master Jan 24, 2024
16 checks passed
@sabban sabban deleted the small_tests_fixes branch January 24, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants