refact "cscli bouncers"

[mmetc]

There are a few patterns there that, if applied consistently to cmd/crowdsec-cli, would enhance maintainability.

• encapsulate reference to global state (even csConfig) via command constructors
• don't export functions if not needed
• it should be possible to split crowdsec-cli in sub-packages (cmd/crowdsec-cli/bouncers) I didn't do it here because we ought to do it with the table helpers first
• no need to parse each flag, or to store them together, or to share them as global vars
• don't ask for more configuration than required (db vs lapi server)
• don't over-indent or overuse closures
• parse flags directly to their type (for time.Duration)
• don't repeat information in user facing messages (i.e. error doing thing with X: tried to blahblah X: failed because X is not Y)

[github-actions]

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (6507e8f) 56.85% compared to head (746e1a9) 56.95%.

Files	Patch %	Lines
cmd/crowdsec-cli/bouncers.go	41.72%	83 Missing and 5 partials ⚠️
cmd/crowdsec-cli/support.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2776      +/-   ##
==========================================
+ Coverage   56.85%   56.95%   +0.09%     
==========================================
  Files         237      237              
  Lines       30640    30632       -8     
==========================================
+ Hits        17419    17445      +26     
+ Misses      11532    11507      -25     
+ Partials     1689     1680       -9     

Flag	Coverage Δ
bats	36.76% <45.39%> (+0.10%)	⬆️
unit-linux	52.23% <75.00%> (-0.01%)	⬇️
unit-windows	47.75% <75.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mmetc]

Actually - we do need to load LAPI configuration because that's how we check the command is running on the right node. But I'll have to nerf the logs in this case

[sabban]

lgtm