Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact "cscli console" #2834

Merged
merged 3 commits into from Feb 12, 2024
Merged

refact "cscli console" #2834

merged 3 commits into from Feb 12, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 11, 2024

No description provided.

@mmetc mmetc added the kind/enhancement New feature or request label Feb 11, 2024
@mmetc mmetc added this to the 1.6.1 milestone Feb 11, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (5c83695) 52.88% compared to head (874aab4) 57.92%.
Report is 2 commits behind head on master.

Files Patch % Lines
cmd/crowdsec-cli/console.go 66.91% 34 Missing and 10 partials ⚠️
cmd/crowdsec-cli/console_table.go 57.14% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2834      +/-   ##
==========================================
+ Coverage   52.88%   57.92%   +5.04%     
==========================================
  Files         238      238              
  Lines       30863    30891      +28     
==========================================
+ Hits        16322    17894    +1572     
+ Misses      12985    11367    -1618     
- Partials     1556     1630      +74     
Flag Coverage Δ
bats 37.84% <66.66%> (+0.02%) ⬆️
unit-linux 52.37% <ø> (?)
unit-windows 47.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit a6a4d46 into master Feb 12, 2024
17 checks passed
@mmetc mmetc deleted the cscli-console branch February 12, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants