Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crowdsec: remove warning if prometheus port is taken during cold logs processing #2857

Merged
merged 2 commits into from Mar 7, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 23, 2024

this removes a Warning log because likely LAPI is behind it

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.6.1 milestone Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.00%. Comparing base (8e9e091) to head (19e5fdc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2857      +/-   ##
==========================================
+ Coverage   57.98%   58.00%   +0.01%     
==========================================
  Files         240      240              
  Lines       31040    31042       +2     
==========================================
+ Hits        18000    18005       +5     
+ Misses      11411    11408       -3     
  Partials     1629     1629              
Flag Coverage Δ
bats 37.99% <100.00%> (+0.01%) ⬆️
unit-linux 52.28% <ø> (+0.01%) ⬆️
unit-windows 47.76% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

...to avoid port conflict warning, also change "acquisition is finished" to Info
@mmetc mmetc changed the title crowdsec: disable prometheus metrics when running time machine crowdsec: remove warning if prometheus port is taken during cold logs processing Mar 7, 2024
@mmetc mmetc merged commit 1eab943 into master Mar 7, 2024
15 checks passed
@mmetc mmetc deleted the disable-oneshot-metrics branch March 7, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants