Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zfs magic for GetFSType #2950

Merged
merged 1 commit into from Apr 25, 2024
Merged

add zfs magic for GetFSType #2950

merged 1 commit into from Apr 25, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Apr 19, 2024

Closes #2949

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Apr 19, 2024

/kind fix
/area agent

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc
Copy link
Contributor

mmetc commented Apr 20, 2024

Maybe the message can be toned down to info?

Also where could we put it to avoid bloating pkg/types again, this is really not useful to bouncers..

  • I still have the warning in freebsd (vagrant) but with ufs:
time="2024-04-19T22:13:29Z" level=warning msg="Crowdsec service shutting down"
time="2024-04-20T06:00:21Z" level=warning msg="unable to determine if database is on network filesystem: unknown fstype 53"
root@opnsense:~ # df -T
Filesystem                Type    1K-blocks    Used   Avail Capacity  Mounted on
/dev/gpt/rootfs           ufs       9897332 3276080 5829468    36%    /
devfs                     devfs           1       1       0   100%    /dev
/dev/gpt/efifs            msdosfs    262129    1773  260356     1%    /boot/efi
devfs                     devfs           1       1       0   100%    /var/dhcpd/dev
devfs                     devfs           1       1       0   100%    /var/unbound/dev
/usr/local/lib/python3.9  nullfs    9897332 3276080 5829468    36%    /var/unbound/usr/local/lib/python3.9
/lib                      nullfs    9897332 3276080 5829468    36%    /var/unbound/lib

@mmetc
Copy link
Contributor

mmetc commented Apr 25, 2024

with the previous PR on the same subject, this looks OK and I'm merging

@mmetc mmetc merged commit ceb4479 into master Apr 25, 2024
15 checks passed
@mmetc mmetc deleted the zfs-detection branch April 25, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZFS is missing in the list of autodetected FS
3 participants