Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: refactor alerts/console/decisions/setup #3003

Merged
merged 9 commits into from
May 31, 2024
Merged

cscli: refactor alerts/console/decisions/setup #3003

merged 9 commits into from
May 31, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 13, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 320 lines in your changes are missing coverage. Please review.

Project coverage is 34.09%. Comparing base (89d02e9) to head (d67dd8b).

Files Patch % Lines
cmd/crowdsec-cli/alerts.go 0.00% 99 Missing ⚠️
cmd/crowdsec-cli/decisions.go 0.00% 75 Missing ⚠️
cmd/crowdsec-cli/console.go 0.00% 72 Missing ⚠️
cmd/crowdsec-cli/setup.go 0.00% 67 Missing ⚠️
cmd/crowdsec-cli/support.go 0.00% 6 Missing ⚠️
cmd/crowdsec-cli/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3003       +/-   ##
===========================================
- Coverage   52.38%   34.09%   -18.30%     
===========================================
  Files         280      279        -1     
  Lines       35431    35467       +36     
===========================================
- Hits        18562    12093     -6469     
- Misses      15029    22063     +7034     
+ Partials     1840     1311      -529     
Flag Coverage Δ
bats ?
unit-linux 34.81% <0.00%> (-0.04%) ⬇️
unit-windows 30.95% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit c1e858c into master May 31, 2024
17 checks passed
@mmetc mmetc deleted the cscli-global branch May 31, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants