Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: remove "dashboard" command #3004

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

cscli: remove "dashboard" command #3004

wants to merge 2 commits into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 13, 2024

#2927

How do we handle this?

debian/prerm
2: cscli dashboard remove -f -y --error || echo "Ignore the above error if you never installed the local dashboard."

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.34%. Comparing base (c1e858c) to head (6ab7f4d).

Files Patch % Lines
cmd/crowdsec-cli/lapi.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
- Coverage   58.41%   53.34%   -5.07%     
==========================================
  Files         268      276       +8     
  Lines       27753    34721    +6968     
==========================================
+ Hits        16212    18523    +2311     
- Misses       9749    14363    +4614     
- Partials     1792     1835      +43     
Flag Coverage Δ
bats 40.86% <80.00%> (+0.68%) ⬆️
unit-linux 35.71% <0.00%> (+0.91%) ⬆️
unit-windows 31.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants