Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: don't set machine heartbeat until first connection #3019

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 17, 2024

here I'm not 100% sure of the behavior we want from prune

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.51%. Comparing base (1d08edc) to head (f5f3bbd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3019      +/-   ##
==========================================
+ Coverage   52.49%   52.51%   +0.02%     
==========================================
  Files         281      281              
  Lines       35421    35425       +4     
==========================================
+ Hits        18593    18603      +10     
+ Misses      15005    15002       -3     
+ Partials     1823     1820       -3     
Flag Coverage Δ
bats 40.21% <100.00%> (-0.04%) ⬇️
unit-linux 34.84% <0.00%> (+<0.01%) ⬆️
unit-windows 30.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added this to the 1.6.3 milestone May 17, 2024
@mmetc mmetc force-pushed the nil-machine-heartbeat branch 3 times, most recently from 01c63e4 to fc27d45 Compare June 4, 2024 15:07
@mmetc mmetc requested a review from LaurenceJJones June 4, 2024 15:09
@LaurenceJJones
Copy link
Contributor

Yop 👋🏻 same on the prune, for me I would expect prune to delete anything that I set the time for so even if the last heartbeat is nil it should go from creation time instead which is what you already done I believe. I will test this PR shortly and give comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants