-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db: don't set machine heartbeat until first connection #3019
base: master
Are you sure you want to change the base?
Conversation
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3019 +/- ##
==========================================
+ Coverage 52.49% 52.51% +0.02%
==========================================
Files 281 281
Lines 35421 35425 +4
==========================================
+ Hits 18593 18603 +10
+ Misses 15005 15002 -3
+ Partials 1823 1820 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
01c63e4
to
fc27d45
Compare
Yop 👋🏻 same on the prune, for me I would expect prune to delete anything that I set the time for so even if the last heartbeat is nil it should go from creation time instead which is what you already done I believe. I will test this PR shortly and give comments. |
fc27d45
to
f5f3bbd
Compare
here I'm not 100% sure of the behavior we want from prune