Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge - experimental context branch #3073

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 10, 2024

No description provided.

@mmetc mmetc added kind/enhancement New feature or request kind/refactoring labels Jun 10, 2024
@github-actions github-actions bot added needs/area and removed kind/enhancement New feature or request labels Jun 10, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 73.94137% with 80 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (bd4540b) to head (a1a6749).
Report is 9 commits behind head on master.

Files Patch % Lines
pkg/database/alerts.go 77.27% 10 Missing ⚠️
pkg/database/decisions.go 73.68% 10 Missing ⚠️
pkg/database/flush.go 57.14% 9 Missing ⚠️
pkg/apiserver/papi.go 0.00% 8 Missing ⚠️
pkg/apiserver/controllers/v1/decisions.go 53.84% 5 Missing and 1 partial ⚠️
pkg/apiserver/papi_cmd.go 0.00% 6 Missing ⚠️
pkg/database/machines.go 79.31% 6 Missing ⚠️
cmd/crowdsec-cli/machines.go 79.16% 3 Missing and 2 partials ⚠️
cmd/crowdsec-cli/bouncers.go 84.21% 3 Missing ⚠️
pkg/apiserver/apic.go 83.33% 2 Missing and 1 partial ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3073      +/-   ##
==========================================
- Coverage   52.49%   52.49%   -0.01%     
==========================================
  Files         281      281              
  Lines       35435    35453      +18     
==========================================
+ Hits        18602    18611       +9     
- Misses      15011    15017       +6     
- Partials     1822     1825       +3     
Flag Coverage Δ
bats 40.25% <62.86%> (-0.03%) ⬇️
unit-linux 34.83% <33.09%> (+<0.01%) ⬆️
unit-windows 30.96% <49.83%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc changed the title do not merge - expect unit tests to fail do not merge - experimental context branch Jun 10, 2024
@mmetc mmetc added this to the 1.7.0 milestone Jun 10, 2024
@LaurenceJJones
Copy link
Contributor

#3089 linking

@mmetc mmetc removed this from the 1.7.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants