Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwt token generation improvement #557

Merged
merged 2 commits into from
Jan 7, 2021
Merged

jwt token generation improvement #557

merged 2 commits into from
Jan 7, 2021

Conversation

registergoofy
Copy link
Contributor

*add some warning comment for those who want to choose their secret
*strictly follow the golang doc for using crypto/rand
*fatal if not enough entropy

*strictly follow the golang doc for using crypto/rand
*fatal if not enough entropy

c
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe check / warn on secret length

pkg/apiserver/middlewares/v1/jwt.go Show resolved Hide resolved
pkg/apiserver/middlewares/v1/jwt.go Show resolved Hide resolved
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@registergoofy registergoofy merged commit eda9c03 into master Jan 7, 2021
@registergoofy registergoofy deleted the jwt branch January 7, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants