Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a mikrotik formatter #20

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Implement a mikrotik formatter #20

merged 1 commit into from
Mar 2, 2023

Conversation

williamdes
Copy link
Contributor

I used this to start this project: https://github.com/0x767676/crowdsec-mikrotik

It works fine, tested in production

@williamdes
Copy link
Contributor Author

@LaurenceJJones
Copy link
Contributor

Hey! Thank you submitting this PR, awesome to see new formats. There a failing lint test once corrected we can work on merging.

@williamdes
Copy link
Contributor Author

Hey! Thank you submitting this PR, awesome to see new formats. There a failing lint test once corrected we can work on merging.

Awesome!
is there any way I could pass a query string to the endpoint to change the default list name?
I am a go newbie so maybe you could help after we merge this first version?

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Feb 24, 2023

is there any way I could pass a query string to the endpoint to change the default list name?

What do you mean by this? I dont use this bouncer or unless it a specific thing to outline with this format?

I am a go newbie so maybe you could help after we merge this first version?

We can do both at the same time if the feature might be needed before people use

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Mar 2, 2023

Currently there no way to pass in query params without making it messy. I want to spend sometime making a v2 of this bouncer that will implement the functions as http handlers instead of functions that returns a string. This will allow the most customisation as possible. So if you happy with the current format we can merge.

@williamdes
Copy link
Contributor Author

Currently there no way to pass in query params without making it messy. I want to spend sometime making a v2 of this bouncer that will implement the functions as http handlers instead of functions that returns a string. This will allow the most customisation as possible. So if you happy with the current format we can merge.

Sure, you can merge it as it is

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurenceJJones LaurenceJJones merged commit 3daa8f6 into crowdsecurity:main Mar 2, 2023
@williamdes
Copy link
Contributor Author

williamdes commented Mar 2, 2023

Thank you!
Can you release this some time soon ?

This PR has a typo fixed by #33

@williamdes williamdes deleted the fmt-microtik branch March 2, 2023 16:58
@williamdes williamdes changed the title Implement a microtik formatter Implement a mikrotik formatter Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants