-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a mikrotik formatter #20
Conversation
Hey! Thank you submitting this PR, awesome to see new formats. There a failing lint test once corrected we can work on merging. |
Awesome! |
What do you mean by this? I dont use this bouncer or unless it a specific thing to outline with this format?
We can do both at the same time if the feature might be needed before people use |
Currently there no way to pass in query params without making it messy. I want to spend sometime making a v2 of this bouncer that will implement the functions as http handlers instead of functions that returns a string. This will allow the most customisation as possible. So if you happy with the current format we can merge. |
Sure, you can merge it as it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! This PR has a typo fixed by #33 |
I used this to start this project: https://github.com/0x767676/crowdsec-mikrotik
It works fine, tested in production