Fix/dp 165 consumer metrics #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2020 14:08
stephenmelrose
approved these changes
Mar 16, 2020
jessecrowdskout
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make Kafka consumer metrics available in Datadog so we don't have to use the weird custom ones that are managed by cs stats. (These will just be collected via JMX).
I have hand-jammed this file on prod-kafka1, so you can see these metrics appearing in datadog.
For example, go check out the kafka.consumer_lag metric with a tag equal to one of these topics:
I don't actually know how to correctly test and deploy this change.